feat(P3): implement additional rates + some fixes#681
Open
haakon-e wants to merge 14 commits into
Open
Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
1 task
haakon-e
changed the base branch from
he/docs-improve-formatting-fix-typo
to
main
haakon-e
force-pushed
the
he/update-p3-melting
branch
3 times, most recently
from
eeadbe5 to
1f5f9a8
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
1f5f9a8 to
c172fe9
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
fbd7881 to
e88d224
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
c172fe9 to
5e20908
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
e88d224 to
f5021ff
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
5e20908 to
85389a5
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
f5021ff to
5c10212
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
85389a5 to
07bcdda
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
5c10212 to
c06175b
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
07bcdda to
e3cf649
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
2 times, most recently
from
ec34417 to
d3091fb
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
2 times, most recently
from
f0ea9b8 to
e1dd6a8
Compare
haakon-e
commented
Mar 2, 2026
Member
Author
haakon-e
left a comment
haakon-e
left a comment
There was a problem hiding this comment.
comments to assist review.
| dn_ice_dt += n_dep | ||
| dq_ice_dt += m_dep | ||
| dq_rim_dt += m_dep | ||
| db_rim_dt += m_dep / 900 |
Member
Author
There was a problem hiding this comment.
dividing by 900 here is related to my note to self in src/parameters/MicrophysicsP3.jl. Need to check which ice densities I need.
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
d3091fb to
9a89238
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
e1dd6a8 to
3223573
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
9a89238 to
d11950c
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
3223573 to
14b07f3
Compare
haakon-e
changed the title
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
d11950c to
74e6b25
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
14b07f3 to
d1764d5
Compare
trontrytel
reviewed
Mar 20, 2026
trontrytel
reviewed
Mar 20, 2026
trontrytel
approved these changes
Mar 20, 2026
Member
trontrytel
left a comment
trontrytel
left a comment
There was a problem hiding this comment.
Left some comments. Looks great, and I'm sure we will have more fixes as we start running it in Atmos
trontrytel
added
Approved 🍀
and removed
Needs review
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
e6b719c to
737a3ea
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
f49bff2 to
7ef4121
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
737a3ea to
4ecaff8
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
7ef4121 to
b86c198
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
4ecaff8 to
e6bcd40
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
b86c198 to
6badb1a
Compare
haakon-e
force-pushed
the
he/fix-2m-tendencies
branch
from
e6bcd40 to
e0496e3
Compare
haakon-e
force-pushed
the
he/update-p3-melting
branch
from
6badb1a to
f7f4661
Compare
- To improve compilation of some GPU kernels, provide an unrolled implementation of logsumexp
new tendencies for bulk 2M scheme: - ice self-collection - ice sublimation / vapor deposition - empirical ice nucleation (Frostenberg mean) - ice number adjustment tendency numerics: - add numeric epsilon for rime volume - squash a few bugs - improve docs
haakon-e
force-pushed
the
he/update-p3-melting
branch
2 times, most recently
from
2843f77 to
cb8f657
Compare
- P3State surface + thresholds + segment_boundaries + subintervals + ρq_ice/ρn_ice rename
- self-collection, sublimation, F23-mean, number adjustment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new rates for the 2M (with P3) microphysics scheme, including
Notably, these additional rates mean ice number is now adjusted by the P3 scheme.
Additional changes include
het_ice_nucleationandice_meltbydt