Support combining distributed output for FieldTimeSeries with Reduced directions#5188
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5188 +/- ##
==========================================
- Coverage 72.93% 72.30% -0.64%
==========================================
Files 393 393
Lines 21872 22135 +263
==========================================
+ Hits 15953 16005 +52
- Misses 5919 6130 +211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't understand what the PR does from the title -- are you saying that sometimes we get |
|
Reading the code I think the issue is when some locations of the field in question are |
|
Hm.... CliMA/ClimaSeaIce.jl#109 passed. |
|
Ah yeah, it was the combining of distributed fields that does not pass because it assumed halos in z-direction, so I was trying with single ranks basically if one direction is a |
Nothing distributed fieldtimeseriesFieldTimeSeries with Reduced directions
Needed for CliMA/ClimaSeaIce.jl#109 to pass