Skip to content

Support combining distributed output for FieldTimeSeries with Reduced directions#5188

Merged
simone-silvestri merged 4 commits into
mainfrom
ss/nothing-combination-distributed
Jan 23, 2026
Merged

Support combining distributed output for FieldTimeSeries with Reduced directions#5188
simone-silvestri merged 4 commits into
mainfrom
ss/nothing-combination-distributed

Conversation

@simone-silvestri
Copy link
Copy Markdown
Collaborator

Needed for CliMA/ClimaSeaIce.jl#109 to pass

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.30%. Comparing base (2781181) to head (d00df50).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5188      +/-   ##
==========================================
- Coverage   72.93%   72.30%   -0.64%     
==========================================
  Files         393      393              
  Lines       21872    22135     +263     
==========================================
+ Hits        15953    16005      +52     
- Misses       5919     6130     +211     
Flag Coverage Δ
buildkite 68.23% <0.00%> (-0.03%) ⬇️
julia 68.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glwagner
Copy link
Copy Markdown
Member

I don't understand what the PR does from the title -- are you saying that sometimes we get nothing instead of FieldTimeSeries? How does this happen?

@glwagner
Copy link
Copy Markdown
Member

Reading the code I think the issue is when some locations of the field in question are Nothing?

@navidcy
Copy link
Copy Markdown
Member

navidcy commented Jan 22, 2026

Hm.... CliMA/ClimaSeaIce.jl#109 passed.

@simone-silvestri
Copy link
Copy Markdown
Collaborator Author

simone-silvestri commented Jan 22, 2026

Ah yeah, it was the combining of distributed fields that does not pass because it assumed halos in z-direction, so I was trying with single ranks
https://github.com/CliMA/ClimaSeaIce.jl/blob/61451d83921321b0ac38577c58c77b29e5495fae/test/test_distributed_sea_ice.jl#L134-L138

basically if one direction is a Nothing we need to avoid computing the range with the halos

@simone-silvestri simone-silvestri changed the title Support combining Nothing distributed fieldtimeseries Support combining distributed output for FieldTimeSeries with Reduced directions Jan 22, 2026
Comment thread src/OutputReaders/combining_field_time_series.jl Outdated
@navidcy navidcy added distributed 🕸️ Our plan for total cluster domination output 💾 labels Jan 22, 2026
@simone-silvestri simone-silvestri merged commit c74aa9b into main Jan 23, 2026
78 checks passed
@simone-silvestri simone-silvestri deleted the ss/nothing-combination-distributed branch January 23, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distributed 🕸️ Our plan for total cluster domination output 💾

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants