[hoorayimhelping]

Summary

• Replaces Divider with Separator in sources list

Screenshots or video

How to test on Vercel preview

Preview routes: /team

Steps:

1. Open the Vercel preview. In onboarding, click Connect to Demo Server.
2. Go to /team in the address bar. The nav hides Team Settings in this mode. Then look at the lines between sources on the Data tab.
3. Open a log source with its chevron, and click Configure Optional Fields. Look at the lines between the field groups.
4. Open a trace source and look at the lines between its field groups. Click Add Materialized View to see the line under the materialized view settings.

[changeset-bot]

🦋 Changeset detected

Latest commit: b245273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hyperdx-oss	Ready	Preview	Nov 10, 2026 7:51pm UTC
hyperdx-storybook	Ready	Preview	Nov 10, 2026 7:51pm UTC

[github-actions]

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

• Production files changed: 4
• Production lines changed: 43
• Branch: bucky-sources-list-separator
• Author: hoorayimhelping

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

PR Review

✅ No issues found.

[github-actions]

Duplicate code analysis

No new duplicate code introduced by this PR.

---

jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 110 in total (1.20%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

[github-actions]

Deep Review

✅ No critical issues found.

This is a clean, self-contained presentational refactor: every bare Mantine <Divider /> is replaced with click-ui <Separator size="xs" /> across the sources list and source-form components, with the now-unused Divider import removed from each file and Separator folded into the existing @clickhouse/click-ui imports. No conditional-render logic (e.g. index < (sources?.length ?? 0) - 1 in SourcesList.tsx) was touched, and none of the replaced dividers carried props, so no styling or behavior was silently dropped. The swap matches the established pattern at packages/app/src/components/TeamSettings/WebhooksSection.tsx:189 and is explicitly endorsed by the repo's agent_docs/code_style.md (prefer click-ui over Mantine for simple primitives like Separator). The changeset is valid: @hyperdx/app / patch is correct for a cosmetic change.

No P0, P1, P2, or P3 findings survived re-grading. The reviewers' only residual notes are visual-spacing observations (click-ui Separator may render different intrinsic margins than Mantine Divider inside Mantine Stack/Box containers), which are not code defects and are already covered by the before/after screenshots in the PR description.

---

Reviewers (4): correctness, maintainability, kieran-typescript, project-standards.

Testing gaps: No automated coverage asserts separator rendering in the sources list or source form; the swap is verified by convention, existing usage, and the PR's before/after screenshots rather than tests — acceptable for a purely presentational change.

[github-actions]

E2E Test Results

✅ All tests passed • 465 passed • 1 skipped • 1457s

Status	Count
✅ Passed	465
❌ Failed	0
⚠️ Flaky	1
⏭️ Skipped	1

Tests ran across 4 shards in parallel.

View full report →