Skip to content

fix(api): load connection passwords in the usage stats job #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordan-simonovski merged 1 commit into from
Nov 10, 2026
+7 −1
Merged

fix(api): load connection passwords in the usage stats job #3613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/usage-stats-connection-password.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@hyperdx/api': patch
---

fix: usage stats job no longer fails ClickHouse auth on password-protected
connections
2 changes: 1 addition & 1 deletion packages/api/src/tasks/usageStats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ function extractTableNames(source: SourceDocument): string[] {

const getClickhouseTableSize = async () => {
// fetch mongo data
const connections = await Connection.find();
const connections = await Connection.find().select('+password');

@github-actions github-actions Bot Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 minor — No regression test that the usage stats job sends the connection password to ClickHouse

Add a case to packages/api/src/tasks/__tests__/usageStats.test.ts, which never mentions Connection or password today. It should create a Connection with a password, mock ClickhouseClient, and assert the constructor receives that password. The catch {} at usageStats.ts:220 swallows auth errors, so if someone drops .select('+password') again the job fails silently and nothing catches it.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

const sources = await Source.find();

// build map for each db instance
Expand Down
Loading