Skip to content

chore(ci): set top-level permissions on workflows #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ci): set top-level permissions on workflows #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-health-checkup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
env:
HUSKY: 0

permissions:
contents: read

jobs:
build:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
env:
HUSKY: 0

permissions:
contents: read

jobs:
code-quality-checks:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
env:
HUSKY: 0

permissions:
contents: read

jobs:
unit-tests:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/visual-regression-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
env:
HUSKY: 0

permissions:
contents: read

@cursor cursor Bot Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing actions: write permission breaks artifact upload

Medium Severity

Setting top-level permissions with only contents: read causes all other permissions (including actions) to default to none. The actions/upload-artifact@v6 action (v4+) requires actions: write to upload artifacts via the new backend. This means the "Upload test results" step will fail when visual regression tests fail, preventing developers from accessing the Playwright report needed to debug failures.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0206dda. Configure here.


jobs:
visual-regression:
runs-on: ubuntu-latest
Expand Down