ci(publish): run publish workflows on Node 24, drop npm@latest upgrade - #1152
Merged
Conversation
… upgrade `npm install -g npm@latest` now pulls npm 12, which dropped support for Node 23 (EBADENGINE: requires ^22.22.2 || ^24.15.0 || >=26.0.0). Both publish workflows pinned node-version 23.x, so the "Upgrade npm for OIDC support" step failed and no publish ever ran. Bump both workflows to Node 24.x, which bundles npm 11.16+ — new enough for OIDC trusted publishing on its own — and remove the now-unnecessary global npm upgrade step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ariser
approved these changes
Jul 21, 2026
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-gtg2tt4wn-clickhouse.vercel.app Built from commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v1.0.0-rc1publish run failed at the Upgrade npm for OIDC support step and never published:npm install -g npm@latestnow resolves to npm 12, which dropped support for Node 23 (an odd-numbered, now-EOL line). Both publish workflows pinnednode-version: '23.x', so the step hard-failed with exit code 1 — three steps beforenpm publishever ran.Fix
Bump both publish workflows to Node 24.x and remove the global npm upgrade step:
setup-node@v6withnode-version: '24.x'fetches Node 24.18.0, which bundles npm 11.16.0 — well past the npm 11.5.1 threshold for OIDC trusted publishing (first shipped in Node 24.5.0). So the upgrade step is no longer needed, and pinning to the LTS line avoids futurenpm@latestengine surprises.Files:
.github/workflows/publish.yml.github/workflows/release-publisher.ymlVerified locally with Node 24.11.1:
yarn testandyarn buildboth pass.🤖 Generated with Claude Code