Skip to content

ci(publish): run publish workflows on Node 24, drop npm@latest upgrade - #1152

Merged
DreaminDani merged 2 commits into
mainfrom
fix/publish-node-24-oidc
Jul 21, 2026
Merged

ci(publish): run publish workflows on Node 24, drop npm@latest upgrade#1152
DreaminDani merged 2 commits into
mainfrom
fix/publish-node-24-oidc

Conversation

@DreaminDani

Copy link
Copy Markdown
Contributor

Problem

The v1.0.0-rc1 publish run failed at the Upgrade npm for OIDC support step and never published:

npm error code EBADENGINE
npm error engine Not compatible with your version of node/npm: npm@12.0.1
npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error notsup Actual:   {"npm":"10.9.2","node":"v23.11.1"}

npm install -g npm@latest now resolves to npm 12, which dropped support for Node 23 (an odd-numbered, now-EOL line). Both publish workflows pinned node-version: '23.x', so the step hard-failed with exit code 1 — three steps before npm publish ever ran.

Fix

Bump both publish workflows to Node 24.x and remove the global npm upgrade step:

  • setup-node@v6 with node-version: '24.x' fetches Node 24.18.0, which bundles npm 11.16.0 — well past the npm 11.5.1 threshold for OIDC trusted publishing (first shipped in Node 24.5.0). So the upgrade step is no longer needed, and pinning to the LTS line avoids future npm@latest engine surprises.

Files:

  • .github/workflows/publish.yml
  • .github/workflows/release-publisher.yml

Verified locally with Node 24.11.1: yarn test and yarn build both pass.

🤖 Generated with Claude Code

… upgrade

`npm install -g npm@latest` now pulls npm 12, which dropped support for
Node 23 (EBADENGINE: requires ^22.22.2 || ^24.15.0 || >=26.0.0). Both
publish workflows pinned node-version 23.x, so the "Upgrade npm for OIDC
support" step failed and no publish ever ran.

Bump both workflows to Node 24.x, which bundles npm 11.16+ — new enough
for OIDC trusted publishing on its own — and remove the now-unnecessary
global npm upgrade step.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cb54a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Storybook Preview Deployed

✅ Preview URL: https://click-gtg2tt4wn-clickhouse.vercel.app

Built from commit: 89f1d199457ea901222a2c5feaf5041239ceda00

@DreaminDani
DreaminDani merged commit d225825 into main Jul 21, 2026
9 checks passed
@DreaminDani
DreaminDani deleted the fix/publish-node-24-oidc branch July 21, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants