Quote identifiers on Arrow insert table names - #1026
Open
sankalpsthakur wants to merge 2 commits into
Open
Conversation
insert_arrow concatenated raw database.table, so hyphenated names failed while Client.insert() already used quote_identifier(). Fixes ClickHouse#1014
sankalpsthakur
requested review from
joe-clickhouse and
peter-leonov-ch
as code owners
September 5, 2026 14:14
Signed-off-by: Sankalp Thakur <sankalphimself@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quote database/table identifiers on Arrow insert paths the same way
insert()does viaquote_identifier(), so names that need backquotes work.Validation
pytest tests/unit_tests/test_driver/test_httpclient.py::TestInsertArrowTransportSettings tests/unit_tests/test_driver/test_httpclient.py::TestInsertArrowTableQuoting tests/unit_tests/test_backend_orchestration.py tests/unit_tests/test_driver/test_binding.py -q --tb=short -n 0pytest tests/unit_tests/test_driver -qtest_ctypes.pyexpects compiled Cython extensions; local env usedCLICKHOUSE_CONNECT_SKIP_CYTHON=1), 30 errors (TestQuerysetup connects tolocalhost:8123; other errors from missing numpy). No live ClickHouse server in this run. Integration tests not run.Fixes #1014
AI/LLM disclosure