fix: wrong defaulting of setting enableDatabaseSync to false

[GrigoryPervakov]

Why

omitempty wipes the false value from JSON, and the API server sets the value to default=true

What

Make it a pointer to distinguish a false and "not specified" case.

[Copilot]

Pull request overview

This PR fixes a bug in the ClickHouseCluster API where spec.settings.enableDatabaseSync: false could be dropped during JSON serialization due to omitempty, causing the API server to apply the CRD default (true) instead. It does so by making the field a pointer so the operator can distinguish “not specified” (nil) from an explicit false.

Changes:

• Change ClickHouseSettings.EnableDatabaseSync from bool to *bool to preserve explicit false values.
• Update ClickHouse reconciliation logic to treat nil as enabled (default), and skip only when explicitly false.
• Regenerate deepcopy logic for the new pointer field.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File	Description
internal/controller/clickhouse/sync.go	Updates database-sync gating logic to handle pointer semantics correctly (nil vs explicit false).
api/v1alpha1/zz_generated.deepcopy.go	Regenerated deepcopy to correctly copy the new *bool field.
api/v1alpha1/clickhousecluster_types.go	Changes the API type of enableDatabaseSync to *bool while keeping the CRD default behavior.

Files not reviewed (1)

• api/v1alpha1/zz_generated.deepcopy.go: Generated file

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.