Skip to content

test: retain e2e failure diagnostics and reports - #279

Merged
GrigoryPervakov merged 1 commit into
mainfrom
fix/e2e-failure-diagnostics
Jul 27, 2026
Merged

test: retain e2e failure diagnostics and reports#279
GrigoryPervakov merged 1 commit into
mainfrom
fix/e2e-failure-diagnostics

Conversation

@GrigoryPervakov

Copy link
Copy Markdown
Member

Why

Expose more details for CI and version probe failures

What

Collect more logs from kind in CI, expose more details in version probe

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves failure diagnostics for CI e2e runs and for the controller’s ClickHouse version-probe Job, making it easier to troubleshoot flaky or environment-specific failures in the ClickHouse operator’s test and reconciliation pipelines.

Changes:

  • Persist namespace events as a diagnostic artifact during e2e test failures (in addition to printing them).
  • Add a Ginkgo JSON report output for e2e tests and ensure reports are uploaded.
  • Enhance version-probe failure visibility by falling back to container logs on error and enabling debug console logging; add CI steps to export/upload Kind + cluster state on failures.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/testutil/utils.go Writes full namespace events dump to disk and prints the artifact path for easier CI retrieval.
Makefile Adds --ginkgo.json-report for e2e test runs to retain structured test output.
internal/controller/versionprobe.go Improves probe diagnostics via termination message fallback and debug console logging flags.
internal/controller/versionprobe_test.go Updates unit tests to assert the new version-probe args and termination message policy.
.github/workflows/ci.yaml On e2e failure, exports Kind logs + cluster snapshots and uploads them as artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GrigoryPervakov
GrigoryPervakov merged commit 630f706 into main Jul 27, 2026
27 checks passed
@GrigoryPervakov
GrigoryPervakov deleted the fix/e2e-failure-diagnostics branch July 27, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants