Build perf and profiler targets under MSan#103
Merged
Conversation
The MSan exclusions guarded nothing: net-perf-asio links no Boost library (Boost.System is header-only), and the profiler chain (libbacktrace, libbpf, bpftool) is vendored, so all of it inherits the instrumentation and the from-source libc++. Poco and the AWS SDK remain behind their opt-in options. Fail at configure time when BUILD_AWS is set without BUILD_POCO - s3-perf links silk-perf-http, which only exists with Poco.
There was a problem hiding this comment.
Pull request overview
This PR adjusts Silk’s CMake build gating so performance and profiler targets can be built under MSan, and introduces an explicit configure-time constraint between AWS and Poco perf targets.
Changes:
- Build
net-perf-asiowhenever Boost ≥ 1.75, removing the MSan exclusion. - Allow building the
src/profilersubdirectory under MSan (still gated byBUILD_LIBBACKTRACE). - Fail configuration when
BUILD_AWS=ONbutBUILD_POCO=OFF, sinces3-perfdepends onsilk-perf-http.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/perf/CMakeLists.txt |
Removes MSan gating for net-perf-asio and adds a fatal configure-time check to prevent s3-perf from being enabled without Poco. |
CMakeLists.txt |
Removes the MSan exclusion for adding the src/profiler subdirectory (still requires BUILD_LIBBACKTRACE). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSan exclusions guarded nothing: net-perf-asio links no Boost library (Boost.System is header-only), and the profiler chain (libbacktrace, libbpf, bpftool) is vendored, so all of it inherits the instrumentation and the from-source libc++. Poco and the AWS SDK remain behind their opt-in options. Fail at configure time when BUILD_AWS is set without BUILD_POCO - s3-perf links silk-perf-http, which only exists with Poco.