Adjustments to calculating metrics on JASMIN#48
Merged
Conversation
treigerm
force-pushed
the
jasmin_adjustments
branch
from
ccf676e to
366e44e
Compare
Member
Author
|
I've messed up the commit history here a bit. Once we squash the commits before the squash and merge, I'll manually the commit message to delete all the commits that have already been merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly changes the workflow for how to compute the metrics for all compressors and datasets. The problem was that running the old script would simply sequentially go over all compressors and datasets and compute the metrics. Running the script by itself was getting a bit too slow so this PR allows to parallelize the metric computation in a MapReduce manner:
compute_metrics.pyallows the user to compute the metrics for only a single dataset and compressor (the old functionality of running sequentially is still supported). On JASMIN, I am using this script to submit lots of SLURM jobs to parallelize the metrics computation.concatenate_metrics.pyis used to concatenate the results from thecompute_metrics.pyscript into one CSV.I have also added some exception handling for the metric computations so that if one metric computation produces an error this doesn't terminate the whole script but instead produces a NaN value for that specific metric.