SZ3 and EBCC compressor versions that only have absolute error bound#72
Open
treigerm wants to merge 2 commits into
Open
SZ3 and EBCC compressor versions that only have absolute error bound#72treigerm wants to merge 2 commits into
treigerm wants to merge 2 commits into
Conversation
Collaborator
|
The code looks good to me, the name ... I'm not sure. I think since almost all compressors use the bound remapping, I'd rather name SZ3-Abs -> SZ3 and SZ3 -> SZ3+rel (not a better name at all but maybe more consistent)? The only place where this will really matter is in the tables and plots though and changing the names there is easy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates compressor versions for SZ3 and EBCC that only have the absolute error bound and use the relative to absolute error bound conversion instead of passing relative error bounds to the compressor's built-in relative error bounds.