Exclude hold delivery in the automation.

[RasmusBurge-CG]

Description

To be merged with:
https://github.com/Clinical-Genomics/cigrid-ui/pull/856
Clinical-Genomics/trailblazer#536

Make the queries to Trailblazer that are used in the DeliverService filter out the analyses that are manually set to be held out of automatic delivery

Added

• Term &holdDelivery=false when querying for analyses in trailblazer with API methods:
  • get_analyses_to_deliver_for_order
  • get_analyses_to_deliver_for_case
  • get_all_analyses_to_deliver

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b exclude-hold-delivery -a

How to test

• Deploy Add Hold Delivery functionality trailblazer#536 in trailblazer stage
• Make a few analyses visible in Trailblazer: From the same order, different case, one of them set to hold for automatic delivery
• Call
  • cg deliver case <case_internal_id> -s SD with the case held for automatic delivery
  • cg deliver order -t <ticket_id> -s SD
  • cg deliver all-available

Expected test outcome

• Check that in any case, the case set as hold for automatic delivery is delivered

Review

• Tests executed by
• "Merge and deploy" approved by SD
  Thanks for filling in who performed the code review and the test!

This version is a

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

• Document in ...
• Deploy this branch on ...
• Inform to ...

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[diitaz93]

💯