Skip to content

Nallo deliverables: Remove duplicate d4 file entry#165

Merged
peterpru merged 1 commit into
mainfrom
peterpru-patch-1
Jun 23, 2026
Merged

Nallo deliverables: Remove duplicate d4 file entry#165
peterpru merged 1 commit into
mainfrom
peterpru-patch-1

Conversation

@peterpru

@peterpru peterpru commented Jun 23, 2026

Copy link
Copy Markdown
Member

Description

Production reports and error while storing. The d4 file is no longer generated and should be an optional file. However, cg nallo store case fails. The problem is that the d4 file had a duplicate entry, one set to True and one to False.

Added

Changed

Fixed

  • Nallo: Removed duplicate d4 file entry

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy <branch-name>
hermes-test <command here>

How to test

  • login to ...
  • do ...

Expected test result

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@peterpru peterpru self-assigned this Jun 23, 2026
@peterpru peterpru requested a review from a team as a code owner June 23, 2026 12:54

@eliottBo eliottBo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterpru peterpru merged commit 52b5297 into main Jun 23, 2026
3 checks passed
@peterpru peterpru deleted the peterpru-patch-1 branch June 23, 2026 13:33
@peterpru

Copy link
Copy Markdown
Member Author

In stage:
image

In production:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants