Change keyEquivalent to show the typed character, not the QWERTY key cap label#72
Open
DivineDominion wants to merge 4 commits intoClipy:masterfrom
Open
Change keyEquivalent to show the typed character, not the QWERTY key cap label#72DivineDominion wants to merge 4 commits intoClipy:masterfrom
DivineDominion wants to merge 4 commits intoClipy:masterfrom
Conversation
Contributor
Author
|
Updated for the latest changes to Sauce etc. @Econa77 I'm not 100% certain I caught your intention with this PR. And maybe my description is confusing. Would be happy to discuss alternatives! |
Contributor
Author
|
@Econa77 Just wanted to check if you want to move forward with this |
Contributor
Author
|
@Econa77 Since you merged another PR recently, maybe you could look into this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magnet does a great job translating the character of the pressed key into a key code and a "physical" key label. This PR changes property names to avoid confusion:
KeyCombothat corresponds to a QWERTY keyboard key toqwertyKeyLabelkeyEquivalentto produce a String that corresponds to the actual text character that results from pressing the key, which is needed forNSMenuItemand similar Cocoa/AppKit functionalityFor users of
Magnetthat useKeyCombofor menu item shortcuts (like me), this means that theNSMenuItem.keyEquivalentneeds to be updated when the keyboard layout is changed by the user, e.g. from QWERTY to DVORAK. This PR helps by aligning the meaning of "keyEquivalent" for this.