Repository navigation
feat(plugin): display plugin-backed enterprise edition in workspaces - #413
Open
Pika-Yalei wants to merge 4 commits into
Open
Pika-Yalei wants to merge 4 commits into
Pika-Yalei wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display Enterprise or Community beside the existing bottom-left version number in both the normal workspace and SQL workspace. The edition follows
features.ENTERPRISE_EDITIONfrom the existing global settings response, with loading, retry, and reconnect handling.@Plugin, so the sharedEnterprisePlugininterface is not mistaken for a plugin entry. Keep the existing JAR loading and Binder registration flow.docs/guides/private-plugins.md) and edition-difference regression workflows in the companion private plugin repository.Companion plugin implementation: https://github.com/ClouGence/open-cdm-plugin/pull/1. It provides the shared plugin API, edition marker, and local install/remove scripts; integrate both changes together. Encryption and signature verification are outside the current implementation.
Related Issues
None.
Test Plan (Required)
Details:
build_plugins.sh, restarted separate Console and Sidecar processes, and confirmed Enterprise in both workspaces. Removed it usingremove_plugins.sh, restarted both processes, and confirmed Community.Checklist