Repository navigation
fix: preserve SQL workspace connections and standardize Logback - #415
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening table details could mark a healthy SQL workspace connection as failed, hiding the object list and disabling query actions. Keep the connection in the connected state after a successful metadata response, while preserving failure handling and stale-response guards. Add a reusable browser regression scenario.
Release packages could also fail during Spring Boot logging initialization because DashScope SDK transitively introduced
slf4j-simplealongside Logback. Exclude that provider at the SDK dependency, switch the build-time driver bundler to Logback, and configure its root log level as INFO. This removes the competing provider from application runtime dependencies and distributions without requiring a JVM provider override.Related Issues
None.
Test Plan (Required)
Details:
cd frontend && npm run lint -- --no-fixpassed.cd package && ./all_build.sh webpassed.cd package && ./package.sh --buildpassed and generated all three installation archives. Frontend resources were additionally rebuilt with Node.js 22.22.1 and the archives regenerated successfully.slf4j-simple, and no legacy SLF4J binding. A JVM probe using each archive's libraries selectedLoggerContextand passed Spring Boot logging initialization without a provider override.Checklist