Repository navigation
Conversation
The SQL typography override introduced in ClouGence#251 applies the code font to every descendant of the editor gutter, which also hits Monaco's fold control (div.cldr.codicon.codicon-folding-expanded). The codicon icon font is replaced by Menlo/Monaco, which has no glyph for the chevron, so the gutter shows a hollow box instead of the fold arrow. Exclude .codicon elements from the view-lines / margin-view-overlays typography override so icon fonts keep working.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monaco's fold control in the SQL editor gutter renders as a hollow box (
□) instead of the fold chevron on every foldable line (e.g.SELECT,FROM).The regression comes from the typography override added to
frontend/src/styles/global.lessby #251:That selector also matches Monaco's fold control element
div.cldr.codicon.codicon-folding-expanded. Its codicon icon font gets replaced byMenlo, Monaco, 'Courier New', which has no glyph for the chevron, so the browser draws tofu.This PR excludes
.codiconelements from the override, so icon fonts stay intact while code text and line numbers keep the SQL typography:Screenshots
Related Issues
Regression introduced by #251 (which fixed #241). No existing issue tracks this visual defect; found while reviewing the SQL workspace.
Test Plan (Required)
Details:
Checklist