add support for function code 43#358
Open
Barneey96 wants to merge 3 commits intoCloud-Automation:v4.0-devfrom
Open
add support for function code 43#358Barneey96 wants to merge 3 commits intoCloud-Automation:v4.0-devfrom
Barneey96 wants to merge 3 commits intoCloud-Automation:v4.0-devfrom
Conversation
Member
|
Thanks for your commitment, I did a quick review and it looks fine. Can you bump the minor version in the package.json please as well. Let me run a test just to be sure. |
stefanpoeter
reviewed
May 4, 2026
| assert.equal(undefined, response.body.meiType) | ||
| assert.equal(0x01, response.body.code) | ||
| assert.equal('ILLEGAL FUNCTION', response.body.message) | ||
| }) |
Member
There was a problem hiding this comment.
Kudos for the tests but there should also be a positive test parsing the response. You only test exceptions.
Author
There was a problem hiding this comment.
Thank you so much for taking a look so quickly. I will implement the change requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.