hypervisor: Add unauthenticated methods for read-only endpoints#228
Open
Vikramarjuna wants to merge 4 commits intoCloud-Foundations:masterfrom
Open
hypervisor: Add unauthenticated methods for read-only endpoints#228Vikramarjuna wants to merge 4 commits intoCloud-Foundations:masterfrom
Vikramarjuna wants to merge 4 commits intoCloud-Foundations:masterfrom
Conversation
…ted to align with data showin in the UI
rgooch
requested changes
Apr 18, 2026
| return manager.CheckOwnership(authInfo) | ||
| }) | ||
| srpc.RegisterNameWithOptions("Hypervisor", srpcObj, srpc.ReceiverOptions{ | ||
| UnauthenticatedMethods: []string{ |
Member
There was a problem hiding this comment.
This should be gated with an option. See the imageserver for how this is done.
| "DiscardVmOldUserData", | ||
| "DiscardVmSnapshot", | ||
| "ExportLocalVm", | ||
| "GetCapacity", |
Member
There was a problem hiding this comment.
This and the other methods should not be removed from this list. Unauthenticated methods are not implicitly public methods.
rgooch
requested changes
Apr 25, 2026
| } | ||
|
|
||
| func Setup(manager *manager.Manager, dhcpServer DhcpServer, | ||
| func Setup(config Config, manager *manager.Manager, dhcpServer DhcpServer, |
Member
There was a problem hiding this comment.
Please also move the non-configuration parameters into a Params type, as was done for the Imageserver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UnauthenticatedMethods configuration for hypervisor SRPC service.
These methods don't require TLS client certificates, matching the behavior
of their existing HTTP endpoint equivalents: