Conversation
✅ Deploy Preview for cnpe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Okabe-Junya
left a comment
There was a problem hiding this comment.
Thank you for your great work!
let me review based on this discussion - #73 (comment) :)
I think totally LGTM, left some minor comments, PTAL when you have time
There was a problem hiding this comment.
Seems ko, fr glossary/whitepaper files didn't change the name in this PR and this occurs 404 maybe
There was a problem hiding this comment.
ah, that's definitely broken. it's supposed to fall back to english content, but even the english one is missing now. i'll inspect.
| {{ $versioned = $versioned | append . }} | ||
| {{ end }} | ||
| {{ end }} | ||
| {{ $sorted := sort $versioned "version" "desc" }} |
There was a problem hiding this comment.
The version switcher idea is so nice!
but seems this will potentially cause like
v1 -> v10 -> v2 -> ... -> v9
(since these versions are "string")
so need to fix in the future (no need to fix for now, but need to fix by releasing v10 I think)
There was a problem hiding this comment.
I'll take a look and make sure. It's intended to be SemVer compatible.
There was a problem hiding this comment.
going to do this in a future PR i think. lots of changes in this one already
| <i class="fas fa-language"></i> | ||
| </div> | ||
| <div class="translation-needed-content"> | ||
| <strong>Translation Needed</strong> |
There was a problem hiding this comment.
I think this should support l10n like this:
| <strong>Translation Needed</strong> | |
| <strong>{{ i18n "translation_needed_title" }}</strong> |
(and update each website/i18n/.toml)
Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
…ions Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
Signed-off-by: Colin Griffin <colin@krum.io>
|
@Okabe-Junya I pushed some additional changes. lots of stuff, but we should have full language parity now, with fallback to english versions where now translations exist (yet). |
| - Do you have any questions for us? | ||
| - Legal Reminder: Only the anonymized transcript will be shared with the wider research team; all references to you and your company will be removed. Only a small group of leads will have access to the video to ensure the integrity of the transcript for the duration of the project, after which the video will be deleted. | ||
| - Join the conversation: "Join the ongoing conversation at TAG App Delivery: https://tag-app-delivery.cncf.io/wgs/platforms/" | ||
| - Join the conversation: "Join the ongoing conversation at TAG App Delivery: https://cloudnativeplatforms.com/" |
There was a problem hiding this comment.
References TAG APP Deliver - and should this point at the TCG?

Major updates to website framework to improve translation management and artifact version selection/switching.
.gitignorefix — theresourcespattern was matchingcontent/*/resources/, hiding translated resource pages from the sidebar. Changed to/resourcesto only match Hugo's build output directory.outdated: true) in each language directory, so nothing returns a 404.latest/+v1/folder structure with version switcher support. Version tagging instructions added to the README, emphasizing the use ofgit mvto preserve file history.delanguage config and restored a previously deleted German glossary translation from git history./en/path redirect — Netlify redirect from/en/*to/:splatso English content works via/en/-prefixed URLs.wgs/directories left over from the TAG App Delivery restructure.Workflow changes
outdated: true, frontmatter only) in each language directory so the fallback works.git mv+ restore to preserve history when creating a new version folder. See the README section "Tagging a new version of a whitepaper or artifact" for the full process.outdated: trueand no body content to find pages that need translation.Do not merge without approvals/reviews