Remove linter configs and update language/dependency versions#375
Closed
ydesgagn wants to merge 2 commits into
Closed
Remove linter configs and update language/dependency versions#375ydesgagn wants to merge 2 commits into
ydesgagn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes several local linter configuration files and bumps a handful of language runtimes and dependency versions. The linter config files (
.markdownlint-cli2.yaml,.rubocop.yml,.shellcheckrc,.yamllint.yml) are no longer needed locally and have been deleted. Language runtime versions for Go, Node.js, and PHP have been refreshed, the Redis option default has been pinned to9.0, andmulti_xmlhas been bumped inGemfile.lock. The.gitignorehas also been updated to exclude generateddocs/code-review.mdoutput.Key changes:
.markdownlint-cli2.yaml,.rubocop.yml,.shellcheckrc, and.yamllint.ymllinter configuration filesgoandprotoentries inconfig/languages.yaml)config/languages.yamlconfig/languages.yamllatestto9.0inconfig/options/redis.yamlmulti_xmlfrom 0.9.0 to 0.9.1 inGemfile.lockdocs/code-review.mdto.gitignoreTypes of changes
Checklist
readme.mdincludes sections on introduction, installation, usage, and contributingdocs/architecture.mdincludes sections on the architecture diagram, software units, software of unknown provenance, critical algorithms and risk controls related to PII and security