Use bot PAT for auto-merge approvals and require code owner reviews#377
Merged
Conversation
The branch-protection PUT body in repository_configurator.rb was changed to require_code_owner_reviews: true so the bot's approval (issued via the GH_BOT_PAT machine-user) can satisfy the code-owner review rule. The spec assertion still expected false, breaking the rspec macOS job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the auto-merge approval workflow to use a bot Personal Access Token instead of the default
GITHUB_TOKEN, transfers ownership from an individual to theCloud-Officer/maintainersteam inCODEOWNERS, and enablesrequire_code_owner_reviewson protected branches so code owner approval is enforced.Key changes:
.github/CODEOWNERSto assign ownership to@Cloud-Officer/maintainers(team) instead of@ydesgagn..github/workflows/auto-merge.ymlto authenticate the approve step withsecrets.GH_BOT_PATinstead ofsecrets.GITHUB_TOKEN.lib/ghb/auto_merge_manager.rbto generate the auto-merge workflow with the newGH_BOT_PATsecret.lib/ghb/repository_configurator.rbto setrequire_code_owner_reviews: trueon protected branches.spec/ghb/auto_merge_manager_spec.rbto assert the approve step usessecrets.GH_BOT_PAT.Types of changes
Checklist
readme.mdincludes sections on introduction, installation, usage, and contributingdocs/architecture.mdincludes sections on the architecture diagram, software units, software of unknown provenance, critical algorithms and risk controls related to PII and security