Pin macOS runner to macos-26 and add --sync_required_status_checks flag#381
Merged
Conversation
cloudofficer-admin
previously approved these changes
May 13, 2026
Existing RepositoryConfigurator specs use InstanceDouble(GHB::Options) without the newly added sync_required_status_checks reader; stub it to unblock the mismatch tests. Add a new context that exercises the sync override path (no raise, branch protection rewritten with expected checks while preserving existing app_ids) plus an Options spec proving ephemeral flags are stripped from the persisted args_comment header. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cloudofficer-admin
previously approved these changes
May 13, 2026
Combine put/post/patch stubs via receive_messages, extract the expected branch protection payload into a let, hoist configurator.configure into the before block so the example has a single expectation, switch contexts to %w and use symbol keys in the JSON-roundtripped fixture. Split the ephemeral-flag option test into one assertion per example. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cloudofficer-admin
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the macOS GitHub Actions runner from the
macos-latestrolling tag to the explicitmacos-26image so CI behavior remains stable across runner upgrades, and introduces a new opt-in--sync_required_status_checksflag that letsgithub-buildrepair branch-protection check lists when job or matrix names change (instead of failing with a mismatch error).Key changes:
macos-latestwithmacos-26in the default constant (lib/ghb.rb), the workflow matrix (.github/workflows/build.yml), and theproto/swiftlanguage entries (config/languages.yaml)--sync_required_status_checksCLI option inlib/ghb/options.rb, along with a newEPHEMERAL_FLAGSconstant that strips one-shot flags fromoriginal_argvso they are not persisted to the generated workflow headerlib/ghb/repository_configurator.rb, treat a branch-protection check mismatch as recoverable when the new flag is set: rebuild the remote check list fromexpected_checkswhile preserving each existing entry'sapp_id(so integration-specific configurations such as Xcode Cloud checks are not clobbered)README.mdhelp block anddocs/architecture.mdto document the new option, theEPHEMERAL_FLAGSconstant, and the updated branch-protection sync behaviorTypes of changes
Checklist
readme.mdincludes sections on introduction, installation, usage, and contributingdocs/architecture.mdincludes sections on the architecture diagram, software units, software of unknown provenance, critical algorithms and risk controls related to PII and security