Rename auto-merge workflow to auto-approve and remove legacy file (CI-002)#387
Merged
Conversation
cloudofficer-admin
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated workflow is named "Auto-merge for code owners" but only approves code-owner PRs — it never merges (the merge step was removed in a prior commit). The misnomer surprises maintainers and any downstream automation expecting an auto-merge. This renames it to reflect what it actually does and ensures regenerated repos don't end up running two workflows.
Key changes:
lib/ghb/auto_merge_manager.rb: workflow name → "Auto-approve for code owners"; job:enable_automerge/"Enable Auto-merge" →:auto_approve/"Auto-approve"; concurrency groupauto-merge-*→auto-approve-*; output file →.github/workflows/auto-approve.yml;FileUtils.rm_fthe legacy.github/workflows/auto-merge.ymlon every run so no consumer keeps both workflows.lib/ghb/application.rb: workflow display name updated to match.lib/ghb/workflow/workflow.rb: token-rewrite skip guard widened fromauto-mergetoauto-(merge|approve)so the renamed PAT-based workflow is still excluded from theGITHUB_TOKEN→GH_PATsubstitution.spec/ghb/auto_merge_manager_spec.rb: updated expectations + new test asserting the legacy file is removed.Addresses code-review finding CI-002. Companion PR: Cloud-Officer/ci-actions (regenerated workflow + the batch).
Types of changes
Checklist
Further comments (if required)
On regeneration, every consumer repo's
.github/workflows/auto-merge.ymlis deleted and replaced byauto-approve.yml. The companion ci-actions PR contains the regenerated result; merging that PR is what actually removes the stale file from the consumer repo. No runtime behaviour changes — the workflow still only approves code-owner PRs.