QUAL-017: introduce BuildContext value object for job builders#391
Merged
Conversation
cloudofficer-admin
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the QUAL-017 data-clump finding from the deep code review. The recurring
{ options, old_workflow, new_workflow, file_cache, submodules }keyword-argument clump threaded into every job builder is replaced by a single immutableGHB::BuildContextvalue object. Behaviour-preserving — the existing 321-example suite passes unchanged and RuboCop is clean across all 46 files.Key changes:
lib/ghb/build_context.rb— immutable value object holdingoptions,old_workflow,new_workflow,file_cache,submodules(referenced objects are still mutated in place by the pipeline; only the container is frozen).Application#executebuilds oneBuildContextand passes it to all builders; per-builder extras (unit_tests_conditions,dependencies_commands,code_deploy_pre_steps) remain explicit keyword args alongsidecontext:.initialize(context:, ...)and destructure from it:variables,linter,licenses,language,code_deploy,aws,slackjob builders +gitignore_manager.GHB::BuildContext.new(...).Types of changes
Checklist