Skip to content

fix env in release-image-web.yml - #41

Merged
fuwx295 merged 6 commits into
CloudDetail:release-cifrom
konpure:apo-1.0.0
Aug 5, 2025
Merged

fix env in release-image-web.yml#41
fuwx295 merged 6 commits into
CloudDetail:release-cifrom
konpure:apo-1.0.0

Conversation

@konpure

@konpure konpure commented Aug 5, 2025

Copy link
Copy Markdown

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Summary by Sourcery

Fix incorrect image tagging in GitHub Actions workflows by replacing the IMAGE_BASE variable with explicit REGISTRY_HOST references for both API and web releases.

Bug Fixes:

  • Remove IMAGE_BASE from release-image-web.yml and update tags to use REGISTRY_HOST/kindlingx/apo-dify-web for amd64 and arm64 builds
  • Replace IMAGE_BASE usage in release-image-api.yml with explicit REGISTRY_HOST/kindlingx/apo-dify-api tags

@sourcery-ai

sourcery-ai Bot commented Aug 5, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR streamlines the GitHub Actions workflows by removing the IMAGE_BASE environment variable in both API and web release-image workflows and replacing all tag references with the explicit registry host path for amd64 and arm64 image builds.

File-Level Changes

Change Details Files
Removed IMAGE_BASE env var and updated API workflow image tags
  • Deleted IMAGE_BASE environment variable declaration
  • Replaced ${{ env.IMAGE_BASE }} with explicit ${{ env.REGISTRY_HOST }}/kindlingx/apo-dify-api for amd64
  • Replaced ${{ env.IMAGE_BASE }} with explicit path for arm64 tags
.github/workflows/release-image-api.yml
Removed IMAGE_BASE env var and updated web workflow image tags
  • Deleted IMAGE_BASE environment variable declaration
  • Replaced ${{ env.IMAGE_BASE }} with explicit ${{ env.REGISTRY_HOST }}/kindlingx/apo-dify-web for amd64
  • Replaced ${{ env.IMAGE_BASE }} with explicit path for arm64 tags
.github/workflows/release-image-web.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @konpure - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@fuwx295
fuwx295 merged commit 0065a05 into CloudDetail:release-ci Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants