Skip to content

fix: normalize skill frontmatter for cost-projection, diff-cost-projection, optimize-triage#29

Open
klamb wants to merge 3 commits into
Cloudzero:mainfrom
klamb:fix/skill-frontmatter-consistency
Open

fix: normalize skill frontmatter for cost-projection, diff-cost-projection, optimize-triage#29
klamb wants to merge 3 commits into
Cloudzero:mainfrom
klamb:fix/skill-frontmatter-consistency

Conversation

@klamb

@klamb klamb commented May 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

klamb added 2 commits May 20, 2026 21:18
…optimize-triage

Bumps cost-projection and diff-cost-projection from version 0.1.0 to 1.0.0.
Fixes optimize-triage: adds missing version/author/license fields, converts
block scalar description to a quoted single-line string, and replaces invalid
`Task` tool reference with `Agent` in allowed-tools.
@klamb klamb requested review from a team and mattyellen as code owners May 21, 2026 12:46
author: CloudZero <support@cloudzero.com>
version: 1.0.0
license: Apache-2.0
allowed-tools: Bash, Read, Glob, Grep, WebFetch, Task

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick check on the PR description before merging — it says:

corrects allowed-tools entry from invalid Task name (should be the short-form Task supported by the harness)

That sentence is internally contradictory (changing TaskTask), and the diff confirms this line is unchanged — Bash, Read, Glob, Grep, WebFetch, Task both before and after. Two cases:

  1. The description was edited in haste and allowed-tools simply wasn't touched. Harmless, but worth cleaning up the PR body so future git-log greppers aren't misled.
  2. The intent was to fix Task → something else (e.g., Agent, which is the sub-agent dispatch tool in current Claude Code), and the change got dropped.

Worth a 30-second sanity check because optimize-triage is the only skill in the catalog that declares allowed-tools, and if the correct name is Agent, then Task silently fails to grant permission — which is exactly the symptom your test plan is trying to verify ("confirm it dispatches research agents"). If you run the skill locally and parallel dispatch works, then Task is right and we just need to tidy the PR description; if it doesn't dispatch, fold the rename into this PR while we're already in the file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — you were right on both counts. The original PR description was wrong (the rename got dropped from that commit), and Agent is the correct tool name for sub-agent dispatch. Fixed in 2a5cd79.

@klamb klamb requested a review from qiuz-cz May 22, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants