Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v1.3.2 release preflight was blocked in
make bench-checkduring Phase 0 of the cut-release workflow.Absolute benchmark resource ceilings had drifted below repeated release-host medians, and
BenchmarkEvaluatePolicyTypicalwas flaking at the stored regression envelope.Root Cause
The checked-in perf ceilings and one regression factor were too tight for the current supported Intel macOS release host profile even though the broader regression lane remained stable.
Fix
max_ns_opceilings for the affected benchmark families inperf/resource_budgets.jsonBenchmarkEvaluatePolicyTypical's regression factor inperf/bench_baseline.jsonfrom 4.0x to 4.2x to remove release-host jitter flakeValidation
make bench-checkmake prepush-full