Skip to content

Fixed reading of time variable wave data in yaml input - #168

Merged
wilfchun merged 4 commits into
mainfrom
hotfix/missing-yaml-features
Nov 14, 2025
Merged

wilfchun merged 4 commits into
mainfrom
hotfix/missing-yaml-features

Conversation

@wilfchun

@wilfchun wilfchun commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

This pull request introduces support for configuring wave input modes in the simulation, allowing users to specify whether wave data should come from a fixed value or a time series. It also improves YAML parsing flexibility for raster files and fixes a bug in cliff collapse configuration. The most important changes are grouped below:

Wave Input Mode Configuration

  • Added a new member m_strWaveInputMode to CConfiguration, with corresponding getter and setter methods, and initialized its default value to "fixed". [1] [2] [3] [4]
  • Updated YAML configuration parsing to read a new wave_input_mode parameter, and conditionally load wave data as either fixed values or from time series files based on this mode. If an unknown mode is supplied, an error is reported. [1] [2]
  • Modified application of configuration to use the appropriate wave data source depending on the selected mode.

YAML Parsing Improvements

  • Updated raster files parsing to accept both a list and a single file entry in the YAML configuration, improving user flexibility.

Bug Fix

  • Fixed an assignment bug in the cliff collapse configuration by correctly setting m_bDoCliffCollapse instead of overwriting m_dDeanProfileStartAboveSWL.

@wilfchun wilfchun added bug Something isn't working hotfix Hotfixes labels Nov 14, 2025
@wilfchun
wilfchun marked this pull request as ready for review November 14, 2025 12:42
@wilfchun
wilfchun merged commit 94a8e3f into main Nov 14, 2025
1 check passed
wilfchun added a commit that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hotfix Hotfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant