Fixed reading of time variable wave data in yaml input - #168
Merged
Merged
Conversation
wilfchun
marked this pull request as ready for review
November 14, 2025 12:42
wilfchun
added a commit
that referenced
this pull request
Nov 14, 2025
Update develop with hotfix #168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring wave input modes in the simulation, allowing users to specify whether wave data should come from a fixed value or a time series. It also improves YAML parsing flexibility for raster files and fixes a bug in cliff collapse configuration. The most important changes are grouped below:
Wave Input Mode Configuration
m_strWaveInputModetoCConfiguration, with corresponding getter and setter methods, and initialized its default value to"fixed". [1] [2] [3] [4]wave_input_modeparameter, and conditionally load wave data as either fixed values or from time series files based on this mode. If an unknown mode is supplied, an error is reported. [1] [2]YAML Parsing Improvements
Bug Fix
m_bDoCliffCollapseinstead of overwritingm_dDeanProfileStartAboveSWL.