Require the fetched message count before indexing in header fallback tests - #234
Merged
odrobnik merged 1 commit intoSep 10, 2026
Conversation
…tests `FetchMessageInfoHeaderFallbackTests` asserted `infos.count == 1` with a non-fatal `#expect` and then subscripted `infos[0]`. If the fetch ever returns nothing, the subscript traps and takes the whole test process down, hiding every other result instead of reporting one failed test. Switch the six count checks to `try #require`, which stops the test at the failed count. No behavior change; `swift test --filter FetchMessageInfoHeaderFallbackTests` passes 6 tests, SwiftLint strict is clean. Signed-off-by: Kwang Moo Yi <kmyi@tabmail.ai>
odrobnik
approved these changes
Sep 10, 2026
odrobnik
left a comment
odrobnik
left a comment
Contributor
There was a problem hiding this comment.
No findings. The six changes correctly replace non-fatal count expectations with fatal try #require preconditions before infos[0] access. All affected tests already support throwing, the pattern is established in the same test target, and no production behavior is changed.
👍 No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchMessageInfoHeaderFallbackTestsasserts the fetched count with a non-fatal#expect(infos.count == 1)and then immediately subscriptsinfos[0]. If the fetch ever returns nothing, the subscript traps and takes the whole test process down, hiding every other result instead of reporting one failed test.This switches the six count checks to
try #require(infos.count == 1), matching the pattern already used inEMLByteLevelTests. No behavior change.Verification
swift test --filter FetchMessageInfoHeaderFallbackTests: 6 tests in 1 suite passed.swiftlint lint --strict: clean.Noticed while working on #233; kept separate since it is unrelated test hygiene.