Fix table column min-content fitting - #103
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
odrobnik
added a commit
that referenced
this pull request
Sep 15, 2026
SwiftTextCSS resolved `width` and `max-width` but had no notion of `min-width` at all, so the declaration was parsed as an unknown longhand and dropped — a box could be laid out narrower than its author-specified minimum with no diagnostic. Add `min-width` to ComputedStyle, parse it in the resolver alongside `width`, and honour it in `copyLonghand` so `min-width: inherit` and friends resolve. It is deliberately absent from `inheritedProperties`: min-width is not an inherited property. In block layout the used width is now clamped up to the minimum after the max-width cap, so min-width wins when the two conflict, per CSS 2.1 §10.4. `min-width: auto` resolves to nil and floors at 0, leaving existing layouts unchanged. The box-model tests move into their own suite: adding the min-width layout test pushed RenderPDFTests.swift past SwiftLint's 1200-line file_length limit, so used-width geometry gets a dedicated file the way the text-decoration tests did in #95. The CSS plumbing here was recovered from the abandoned agent/issue-97 branch, found while auditing for work lost to concurrent agents. That branch was a superseded alternative fix for #97, which was resolved differently by #96 and #103 — its competing table column-sizing changes are deliberately not carried over. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #102.