Fix first WebKit table continuation page - #99
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c75d12d54e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let startsOnNewPage = tableRect.height > pageHeight | ||
| && (tableRect.top > pageHeight || offset > pageHeight * 0.25); |
There was a problem hiding this comment.
When a multipage table follows a heading with break-after: avoid and either begins beyond the first page or after the 25% threshold, this sets startsOnNewPage and later inserts a forced page-break marker directly between the heading and table. Forced breaks override the heading's avoid rule, leaving the heading orphaned on the preceding page; the newly added fixture applies exactly this CSS to the heading before its long table but only asserts table-page contents. Move the boundary before the avoid-linked content or otherwise preserve the avoid relationship.
Useful? React with 👍 / 👎.
# Conflicts: # Sources/SwiftTextRender/Layout.swift
1 participant
Resolves #71.