fix(go-runner): ensure test binary exists after execution #52
Conversation
not-matthias
force-pushed
the
cod-2049-symbols-not-shown-in-go-flamegraphs
branch
from
237c421 to
be4253f
Compare
CodSpeed Performance ReportMerging this PR will improve performance by ×9.4Comparing Summary
Performance Changes
Footnotes
|
Unable to generate the flame graphsThe performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
not-matthias
force-pushed
the
cod-2049-symbols-not-shown-in-go-flamegraphs
branch
from
ed45e13 to
ed2f013
Compare
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
not-matthias
force-pushed
the
cod-2049-symbols-not-shown-in-go-flamegraphs
branch
from
9b16278 to
251640a
Compare
| "test", | ||
| // Keep the test binary on disk after executing it. This is required by | ||
| // the runner to properly parse the symbols and debug info. | ||
| "-work", |
There was a problem hiding this comment.
Minor, but is there an easy way to clean this up ?
There was a problem hiding this comment.
Unfortunately no, because we need the test binary to exist when the runner executes the teardown.
The only alternative I see to this, is to parse the first line (and drop it) and then copy the test binary (which is always called {name}.test) to another folder. Wdyt?
| env: | ||
| CODSPEED_GO_PKG_VERSION: ${{ github.head_ref || github.ref_name }} | ||
| with: | ||
| runner-version: branch:cod-2057-perf-timeout-in-codspeed-go-makes-benchmark-hang |
Small downside of this approach: We now have a log like this in the stdout:
WORK=/tmp/go-build3181207056, should we remove it? (not worth it imo, but lmk what you think)Blocked by CodSpeedHQ/codspeed#201