solved Currency dropdown does not close on click outside#161
Closed
mahi656 wants to merge 1 commit intoCode-A2Z:masterfrom
Closed
solved Currency dropdown does not close on click outside#161mahi656 wants to merge 1 commit intoCode-A2Z:masterfrom
mahi656 wants to merge 1 commit intoCode-A2Z:masterfrom
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
archa8
added
the
hacktoberfest-accepted
Member
|
Hey @mahi656, you were not assigned to this issue, so I cannot merge your PR. However, this bug fix works, so I am assigning this PR the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the
CurrencySelectorcomponent by implementing a click-outside-to-close feature. Previously, the dropdown closed only when clicking the button again; now it automatically closes when the user clicks anywhere outside. Implemented usinguseRefanduseEffectto detect outside clicks, improving usability and aligning with standard dropdown behavior.Related Issue:
Fixes # 161
Types of Changes:
How Has This Been Tested?
CurrencySelector.test.jsxsimulating outside clicks to ensure the dropdown closes.Checklist: