fix: add inline variant to Spinner to prevent button expansion#174
Merged
archa8 merged 1 commit intoCode-A2Z:masterfrom Oct 31, 2025
Merged
fix: add inline variant to Spinner to prevent button expansion#174archa8 merged 1 commit intoCode-A2Z:masterfrom
archa8 merged 1 commit intoCode-A2Z:masterfrom
Conversation
✅ Deploy Preview for paisable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a button expansion issue caused by the Spinner component's padding by introducing an inline variant. The solution allows spinners to fit naturally within button content while preserving the original centered spinner for full-page loading states.
- Added
inlineprop to Spinner component with conditional rendering - Updated button loading state in SetupPage to use the new inline variant
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/Spinner.jsx | Added inline prop with conditional rendering for compact 5x5 spinner variant |
| frontend/src/pages/SetupPage.jsx | Updated loading button to use inline spinner variant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue Resolved
Closes #173
Changes
inlineprop to Spinner componentinline={true}, renders a compact 5x5 spinner without padding wrapperinline={false}) maintains original centred spinner with padding for full-page loading states<Spinner inline />variantWhy This Works
Buttons already have their own flex layout and padding. The original spinner's wrapper with
py-10(40px vertical padding) conflicted with button dimensions. The inline variant removes this wrapper, allowing the spinner to fit naturally within button content.Testing
Types of Changes
Checklist