feat(settings form): add exercise category tabs with corresponding multi-select exercise dropdowns#27
Conversation
|
|
@aman-coder03 I’ve updated the issue linked to your PR - will need an additional select dropdown for exercises |
|
sure! working on it! @brysonbw |
|
@brysonbw Ihave implemented the multi-select dropdowns for both exercise categories and individual exercises as requested. The settings now persist correctly and filtering logic has been updated accordingly.
|
|
@brysonbw i have implemented the changes, you can have a look!! |
Ok, smooth. Thanks. Might want to rebase and get latest changes from main - I added select fields as well alongside other changes |
|
done, you can have a look!! |
It seems when you merged and grabbed latest you resolved merge conflicts by accepting your current changes and not incoming (main). Thus, your diff files shows latest main changes being deleted - maybe try undoing latest merge commit on your branch and rebase from main or merge main into your branch again? |
f336179 to
fdb8d47
Compare
|
Synced my branch with latest main, resolved all conflicts, and updated the PR @brysonbw |
…lti-select exercise dropdowns
@aman-coder03 Thanks. Instead of adding comment reviews on the PR, I think collaborating directly is smoother. I also pushed some changes to your working branch. Initially, I was thinking both could be dropdowns. Yet, I think having category tabs with corresponding multi-select exercise dropdowns would be smoother but open to something else if you think differently
If you agree, I left a |
|
@aman-coder03 Thank you for your efforts in looking into this. After reviewing the issue, I don’t believe it qualifies as a “good first issue,” so I’ll assign it to myself for now. I really appreciate your help, and I’m sure there will be other issues better suited to pick up. Likewise, I will close this PR |




this PR adds a multi-select dropdown in the Settings modal that allows users to filter which exercise categories are used when generating random exercises after a Pomodoro session.
included:
images:
fixes #26