Add Ribbon View, Demo Fold Provider, Ribbon Toggles#315
Merged
thecoolwinter merged 8 commits intoCodeEditApp:feat/code-foldingfrom May 29, 2025
Merged
Conversation
thecoolwinter
requested review from
0xWDG,
FastestMolasses,
austincondiff and
matthijseikelenboom
### Description This PR adds the following functionality to the source editor find panel: - Replace: Enables replacing matched text with the specified replacement. - Toggle Match Navigation Wrap-Around: Allows cycling through matches from the beginning when reaching the end. - Toggle Match Case: Adds an option to filter matches by case sensitivity. - Made find panel responsive at small sizes using `ViewThatFits`. ### Related Issues * CodeEditApp#295 * CodeEditApp/CodeEditTextView#1 ### Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots https://github.com/user-attachments/assets/ec23ffe7-6d24-48b7-889a-11a92ec6c147 https://github.com/user-attachments/assets/cfca6d8e-7b97-4258-ae2e-ee82bbf6b9af --------- Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>
austincondiff
approved these changes
May 27, 2025
Collaborator
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
Looks good! Left a few comments for your consideration but they shouldn't get in the way of a merge. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
For reviewers, this is merging into the dev branch. These changes require the version of CETV in this PR. Please pull those changes locally and test using that.
Note
I'll be making some TODOs in the tracking issue #43 for things that aren't included here. Like the overlapping folds UI issue.
Adds the first version of the code folding ribbon, with a very basic folding model.
This is mostly a UI change. It includes changes to the gutter, and a new view for displaying folds. The model and related demo fold provider should be considered incomplete and only for demo purposes.
This also doesn't implement the hover state yet. Just a very basic outline of everything.
Things to review:
FoldingRibbonViewLineFoldingModelGutterViewTextViewControllerCodeEditSourceEditorRelated Issues
Checklist
Screenshots
Light mode.
Dark Mode.
Folds are transparent for scrolling text.
