Add the ability to move selected lines up and down#327
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom Jun 2, 2025
Merged
Add the ability to move selected lines up and down#327thecoolwinter merged 2 commits intoCodeEditApp:mainfrom
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to move selected lines of text up or down within the editor via new controller methods, key bindings, and unit tests.
- Introduces
moveLinesUp()andmoveLinesDown()inTextViewControllerwith undo grouping and selection updates. - Binds Option+Command+[ and Option+Command+] to trigger the new line‐moving actions.
- Adds unit tests covering single‐line and multi‐line move operations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tests/CodeEditSourceEditorTests/Controller/TextViewController+MoveLinesTests.swift | New tests for moving lines up and down in single and multi‐line selections. |
| Sources/CodeEditSourceEditor/Controller/TextViewController+MoveLines.swift | Implements moveLinesUp() and moveLinesDown() with undo grouping. |
| Sources/CodeEditSourceEditor/Controller/TextViewController+LoadView.swift | Adds key bindings for Option+Command+[ and Option+Command+]. |
Comments suppressed due to low confidence (1)
Tests/CodeEditSourceEditorTests/Controller/TextViewController+MoveLinesTests.swift:1
- Missing boundary‐condition tests: there are no tests verifying that moving the very first line up or the very last line down is a no-op.
// TextViewController+MoveLinesTests.swift
Sources/CodeEditSourceEditor/Controller/TextViewController+MoveLines.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+MoveLines.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+MoveLines.swift
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+MoveLines.swift
Show resolved
Hide resolved
be46b2f to
22417c6
Compare
thecoolwinter
approved these changes
Jun 2, 2025
Collaborator
|
Awesome work, thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new methods to
TextViewController:moveLinesUp()moveLinesDown()These methods allow users to move selected lines of text up or down within the text view.
Related Issues
Checklist
Screenshots
I tested a 50k line file to compare performance in Xcode and CodeEdit.
xcode.50k.lines.mov
code.edit.50k.lines.mov