✨ Emphasis API for Highlighting Text Ranges#62
Merged
tom-ludwig merged 7 commits intomainfrom Dec 28, 2024
Merged
Conversation
…14 to support conversion to `CGPath`
thecoolwinter
requested changes
Dec 5, 2024
Contributor
thecoolwinter
left a comment
There was a problem hiding this comment.
Just a spelling error and a file placement suggestion. That smooth path function is beautiful, awesome stuff.
Contributor
|
Excellent work @tom-ludwig! It looks really good. Just a small detail—the animation looks a little off. Instead of scaling it, it seems to be translated from below and to the right. Can we fix this? |
Member
Author
|
@austincondiff Yeah, it’s not what Xcode is using, but honestly, I’m not really a fan of Xcode’s approach. I’ll experiment with the animation to come up with something better. |
Contributor
|
Xcodes approach is a macOS standard found in many other apps. I’d like to first start with it and if we want to, later on adjust as needed. |
thecoolwinter
approved these changes
Dec 23, 2024
austincondiff
approved these changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Emphasis API to highlight specific text ranges within a TextView. This functionality can be used in various scenarios, such as highlighting search results, emphasizing code symbols, or highlighting the code symbol that the mouse is hovering over.
This PR only introduces the Emphasis API and does not include any search functionality or text-range validation (e.g., checking if an already emphasized range has changed).
Note
To test the UI changes, you will likely need to use CESE and add CETE as a local package.
To experiment with the highlighting, add the following snippet to
TextView+KeyDownat line13and change the ranges accordingly:Related Issues
Checklist
Screenshots
Screen.Recording.2024-12-23.at.6.56.48.PM.mov
Multiline:
