Fix CEUndoManager grouping#69
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom Feb 11, 2025
Merged
Conversation
hi2gage
commented
Feb 10, 2025
austincondiff
approved these changes
Feb 10, 2025
Contributor
austincondiff
left a comment
There was a problem hiding this comment.
Nice catch, looks good!
thecoolwinter
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #68
DelegatedUndoManagerdoes not overrideso calling
here and here does not undo as group as expected.
I also updated the names to match between the
CEUndoManagerandUndoManager.Related Issues
Checklist
Screenshots
Before:
CEUndoManager_before.mov
After:
CEUndoManager_after.mov