Merged
Conversation
thecoolwinter
requested changes
Mar 31, 2025
Contributor
thecoolwinter
left a comment
There was a problem hiding this comment.
Works like a charm, can I just request a small re-arrange? I dislike this new enum being in the TextSelection file (since that's a specific struct type and is unrelated).
Could we rename it to CursorSelectionMode and move it to it's own file?
Member
Author
|
Updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are 3 different selection modes that editors typically have when clicking and dragging the mouse.
This PR tracks and implements the different selection mode behaviors.
Related Issues
Closes #74
Checklist
Screenshots
Character selection (default behavior, unchanged)
Screen.Recording.2025-03-30.at.6.12.36.AM.mov
Double click for word selection
Screen.Recording.2025-03-30.at.6.14.26.AM.mov
Triple click for line selection
output.mov