Refactor filters logic#1164
Merged
cfreedman merged 7 commits intoApr 17, 2025
Merged
Conversation
… untangled from the dimensionfilter wrapper
…d formatting the filters view so that it looks identical to before
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
adamzev
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of various filters in the filter view for the map page to reduce the previous complexity and previous unnecessary interfacing of some of the different filter types with unused props.
The previous implementation grouped everything under the
DimensionFilterthat encompassed all the various filter types (button group, panels, multiselect) and derived multiple internal states from the filter context to pass into the subfilters depending on their need. The current changes allow each filter type to handle their individual interactions with the filter context by calling it locally and dispatching any changes. This requires a bit more visible code in theFilterViewto render the different filter groups in the page, but simplifies the link between the filter context and the components that interface with it as well as removing some derived state patterns.