Unit testing for some of the basic services#1183
Closed
cfreedman wants to merge 23 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
…the pipeline code
…- commented out different diff reports and slack updates to focus on the caching and loading mechanism for now, will add them back in later
… it working for running and caching files in geoparquet form
…oss the different class methods
… loading of source files
Contributor
|
This pull request seems to have a lot going on it. I see some stuff on switching from the old pipeline to the new (script to main.py), removing postgres, and adding the tests. Also some functionality is commented out such as sending data to Slack. We may want to remove that but wouldn't just want to leave it as a comment. I see this is a draft. I take it we'll separate out those changes in different merge requests? |
Contributor
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm that you have done the following:
stagingbranch, NOT againstmainDescription
This PR introduces some unit test coverage of the several of the services called in the pipeline. It focuses on the more basic ones without any needs to hit an external API, and rather those that do some extra calculations or transformations on the present dataset when they are called.
Related Issue(s)
This is a partial answer to #1178 with additional testing still needed.