Nick magidson/1196 add reset filter button#1233
Closed
NickMagidson wants to merge 3 commits into
Closed
Conversation
Weekly PR from Staging to Main
* feat: Unvendor awkde * chore: Remove unused dev dependencies and pin versions * chore: Alphabatize backend dependencies * chore: Pin backend dependencies to minor versions * Basic technologies documentation (CodeForPhilly#1184) Add in additional documentation about different technologies used in the project for reference for newcomers. Can continue to flush it out as our pipeline gets more settled. --------- Co-authored-by: Graham Beckley <gbeckley@mozilla.com> Co-authored-by: Nissim Lebovits <111617674+nlebovits@users.noreply.github.com> Co-authored-by: Collum Freedman <30787117+cfreedman@users.noreply.github.com> Co-authored-by: Adam Levin <zev105@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
@NickMagidson Like on the other PR, you'll want to remove all files that aren't in |
Collaborator
|
Hi @NickMagidson , I'm realizing this ticket was addressed by #1206! It might not be live on the site yet because we haven't merged to deployment in a while. I'll get on that. I'm going to go ahead and close this--sorry for not having caught that earlier. But there are still plenty of open FE tickets! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Reset Filter Button
Checklist:
Before submitting your PR, please confirm that you have done the following:
stagingbranch, NOT againstmainDescription
This button will clear out all filter selections. On press, I pass 'CLEAR_DIMENSIONS' in the dispatch from useFilter. I used this method to stay consistent with how it's being used elsewhere in the code.
Related Issue(s)
This PR addresses issue #1196
Type of change
How Has This Been Tested?
I tested to see if the filter would clear using a variety of different filter combinations. With that, I made sure the filter would clear on different zoom levels while still maintaining the state of "total properties" in accordance to what is visually present on the map.