Skip to content

docs(storage): link upstream gitsheets#184 from staleness section #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themightychris merged 1 commit into from
May 19, 2026
Merged

docs(storage): link upstream gitsheets#184 from staleness section #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/behaviors/storage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ This is why the hot-reload path uses `Store.swapPublic` (`apps/api/src/store/sto

**Today** that means `slug-history` and `revocations` — neither has live exposure (no current route handler reads them post-write in the same request), but tests that verify a transact landed on those sheets must use `git show HEAD:…` or `swapPublic` themselves. When a future redirect handler does read slug-history post-write, the correct fix is to load it into the typed in-memory `Store` like the other sheets, not to call `swapPublic` per request.

Upstream gitsheets enhancement tracked at the issue linked from [#47](https://github.com/CodeForPhilly/codeforphilly-ng/issues/47).
Upstream gitsheets enhancement filed at [JarvusInnovations/gitsheets#184](https://github.com/JarvusInnovations/gitsheets/issues/184) (per-sheet `refresh()`). When that lands, tests + future direct-read code can replace the `git show HEAD:…` fallback with `await sheet.refresh(); await sheet.queryAll()`.

## Commits are the audit log

Expand Down