Skip to content

Conversation

@gavofyork
Copy link

No description provided.

gumb0 and others added 27 commits September 30, 2019 14:19
Implement EIP-2046 Reduced gas cost for static calls made to precompiles in LegacyVM
Charge a reduced gas fee for calls to functions within the same contract
The tests exercise CALL/CALLCODE/DELEGATECALL/STATICCALL
Remove need for eip1380 schedule flag

Simplify gas adjustment for call-self case

Make minor updates to call self VM test
Update consensus tests
Update EVMC
- use C++14 standard (needed for intx library)
- add library intx v0.4.0, fetched via Hunter
- include intx, s/u256/intx::uint256, s/u512/intx::uint512
- replaced all boost::multiprecision by equivalent intx constructs
- replaced VM::exp256 by intx::exp (also uses fast squaring algorithm)
"stylistic nitpick: avoid repeating the type"

Co-Authored-By: Andrei Maiboroda <andrei@ethereum.org>
+declare negative flags as const, naming in camelCase
(suggestion from code review by gumb0)
Implement eip1380 (call-to-self) in LegacyVM
…_intx_instead_of_boost_multiprecision

Use intx instead of boost::multiprecision in aleth-interpreter
Comment on lines 3 to 6
## [1.9.0] - Unreleased

- Added: [#5868](https://github.com/ethereum/aleth/pull/5868) `test_importRawBlock` RPC method reports the detailed reason when import fails.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [1.9.0] - Unreleased
- Added: [#5868](https://github.com/ethereum/aleth/pull/5868) `test_importRawBlock` RPC method reports the detailed reason when import fails.
## [1.9.0] - Unreleased
- Added: [#5868](https://github.com/ethereum/aleth/pull/5868) `test_importRawBlock` RPC method reports the detailed reason when import fails.

<< " --force-nonce <n> Override the nonce for any transactions to be signed." << endl
<< endl
<< "Encryption configuration:" << endl
<< " --kdf <kdfname> Specify KDF to use when encrypting (default: sc rypt)" << endl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		<< "    --kdf <kdfname>  Specify KDF to use when encrypting (default: scrypt)" << endl

@@ -0,0 +1,15 @@
# EditorConfig helps developers define and maintain consistent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Language: Cpp

BasedOnStyle: Chromium

AccessModifierOffset: -4
AlignAfterOpenBracket: DontAlign
AlignConsecutiveAssignments: false
AlignConsecutiveDeclarations: false
AlignEscapedNewlinesLeft: true
AlignOperands: true
AlignTrailingComments: true
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: true
BinPackParameters: true
BreakBeforeBinaryOperators: None
BreakBeforeBraces: Custom
BraceWrapping:
AfterClass: true
AfterControlStatement: true
AfterEnum: true
AfterFunction: true
AfterNamespace: true
AfterObjCDeclaration: true
AfterStruct: true
AfterUnion: true
BeforeCatch: true
BeforeElse: true
IndentBraces: false
SplitEmptyFunction: false
BreakBeforeTernaryOperators: false
BreakConstructorInitializers: BeforeColon
ColumnLimit: 100
CommentPragmas: '^ IWYU pragma:'
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 2
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DerivePointerAlignment: false
DisableFormat: false
ExperimentalAutoDetectBinPacking: false
ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ]
IncludeCategories:

Local includes "":

  • Regex: '^".*'
    Priority: 1

Third party libraries:

  • Regex: '^<cryptopp/.*'
    Priority: 70

Standard library extensions / common generic purpose libraries:

  • Regex: '^<boost/.*'
    Priority: 80

Testing libraries:

  • Regex: '^<benchmark/.*'
    Priority: 90
  • Regex: '^<gtest/.*'
    Priority: 90

Public includes <>:

  • Regex: '^<.*.h|hpp>'
    Priority: 2

Standard library:

  • Regex: '^<.*'
    Priority: 100

Anything else:

  • Regex: '.*'
    Priority: 4

IndentCaseLabels: false
IndentWidth: 4
IndentWrappedFunctionNames: false
KeepEmptyLinesAtTheStartOfBlocks: false
MacroBlockBegin: ''
MacroBlockEnd: ''
MaxEmptyLinesToKeep: 2
NamespaceIndentation: None
ObjCBlockIndentWidth: 2
ObjCSpaceAfterProperty: false
ObjCSpaceBeforeProtocolList: false
PenaltyBreakAssignment: 1
PenaltyBreakBeforeFirstCallParameter: 1
PenaltyBreakComment: 50
PenaltyBreakFirstLessLess: 120
PenaltyBreakString: 1000
PenaltyExcessCharacter: 1000000
PenaltyReturnTypeOnItsOwnLine: 200
PointerAlignment: Left
ReflowComments: true
SortIncludes: true
SpaceAfterCStyleCast: false
SpaceBeforeAssignmentOperators: true
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 2
SpacesInAngles: false
SpacesInContainerLiterals: true
SpacesInCStyleCastParentheses: false
SpacesInParentheses: false
SpacesInSquareBrackets: false
Standard: Auto
TabWidth: 4
UseTab: Never
...

# VS stuff
build
ipch
*.sdf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Language: Cpp

BasedOnStyle: Chromium

AccessModifierOffset: -4
AlignAfterOpenBracket: DontAlign
AlignConsecutiveAssignments: false
AlignConsecutiveDeclarations: false
AlignEscapedNewlinesLeft: true
AlignOperands: true
AlignTrailingComments: true
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: true
BinPackParameters: true
BreakBeforeBinaryOperators: None
BreakBeforeBraces: Custom
BraceWrapping:
AfterClass: true
AfterControlStatement: true
AfterEnum: true
AfterFunction: true
AfterNamespace: true
AfterObjCDeclaration: true
AfterStruct: true
AfterUnion: true
BeforeCatch: true
BeforeElse: true
IndentBraces: false
SplitEmptyFunction: false
BreakBeforeTernaryOperators: false
BreakConstructorInitializers: BeforeColon
ColumnLimit: 100
CommentPragmas: '^ IWYU pragma:'
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 2
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DerivePointerAlignment: false
DisableFormat: false
ExperimentalAutoDetectBinPacking: false
ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH ]
IncludeCategories:

Local includes "":

  • Regex: '^".*'
    Priority: 1

Third party libraries:

  • Regex: '^<cryptopp/.*'
    Priority: 70

Standard library extensions / common generic purpose libraries:

  • Regex: '^<boost/.*'
    Priority: 80

Testing libraries:

  • Regex: '^<benchmark/.*'
    Priority: 90
  • Regex: '^<gtest/.*'
    Priority: 90

Public includes <>:

  • Regex: '^<.*.h|hpp>'
    Priority: 2

Standard library:

  • Regex: '^<.*'
    Priority: 100

Anything else:

  • Regex: '.*'
    Priority: 4

IndentCaseLabels: false
IndentWidth: 4
IndentWrappedFunctionNames: false
KeepEmptyLinesAtTheStartOfBlocks: false
MacroBlockBegin: ''
MacroBlockEnd: ''
MaxEmptyLinesToKeep: 2
NamespaceIndentation: None
ObjCBlockIndentWidth: 2
ObjCSpaceAfterProperty: false
ObjCSpaceBeforeProtocolList: false
PenaltyBreakAssignment: 1
PenaltyBreakBeforeFirstCallParameter: 1
PenaltyBreakComment: 50
PenaltyBreakFirstLessLess: 120
PenaltyBreakString: 1000
PenaltyExcessCharacter: 1000000
PenaltyReturnTypeOnItsOwnLine: 200
PointerAlignment: Left
ReflowComments: true
SortIncludes: true
SpaceAfterCStyleCast: false
SpaceBeforeAssignmentOperators: true
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 2
SpacesInAngles: false
SpacesInContainerLiterals: true
SpacesInCStyleCastParentheses: false
SpacesInParentheses: false
SpacesInSquareBrackets: false
Standard: Auto
TabWidth: 4
UseTab: Never
...

@wizzfile
Copy link

wizzfile commented Apr 4, 2020

access

Copy link

@wizzfile wizzfile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@wizzfile
Copy link

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.