This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Feature/week 1 exercises#199
Open
SyedArslanHaider wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Conversation
nsi88
approved these changes
Oct 23, 2024
nsi88
left a comment
nsi88
left a comment
There was a problem hiding this comment.
Looks good. Feels that it's too easy for you)
Do you have any particular questions in there maybe?
| console.log(`The base part of ${filePath} is ${base}`); | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const lastDotIndex = filePath.lastIndexOf("."); | ||
| const ext = filePath.slice(lastDotIndex + 1); |
There was a problem hiding this comment.
Just to give you an alternative. Could be:
filePath.split('.')[1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learnings
hi ,
I hope this message finds you well. I have completed the JavaScript problems for my first week and have submitted my pull request for your review.
If you have the time, I would greatly appreciate any feedback or suggestions you may have. Your insights would be invaluable as I continue to improve my skills.
Thank you very much for your support!