NW6 | ZELIHA PALA | Module Servers | [TECH ED] Chat Server API Project | Week 2 #168
Open
zelihapala wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
NW6 | ZELIHA PALA | Module Servers | [TECH ED] Chat Server API Project | Week 2 #168zelihapala wants to merge 4 commits intoCodeYourFuture:mainfrom
zelihapala wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
|
garydev10
reviewed
Apr 25, 2024
| } | ||
|
|
||
| const newMessage = { | ||
| id: messages.length, |
There was a problem hiding this comment.
Good job to try assign new ID. However, this may end up duplicating ID from a previous message (e.g. if you added a message, deleted it, and then added a new one). Can you think why it may be problematic? How could you avoid this issue if you wanted to?
Author
There was a problem hiding this comment.
Thank you for your reviews @garydev10 . I will work on it .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.