NW6 |Zeliha Pala| JS2 | Codewars -API - Project #17
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zelihapala
changed the title
zelihapala
changed the title
Member
SallyMcGrath
left a comment
SallyMcGrath
left a comment
There was a problem hiding this comment.
Nice job! Have you made other web components now?
| <p>Honor: ${this.userData.honor}</p> | ||
| <p>Clan: ${this.userData.clan}</p> | ||
| <p>Leaderboard Position: ${this.userData.leaderboardPosition}</p> | ||
| <p>Total Authored Challenges: ${this.userData.codeChallenges.totalAuthored}</p> |
Member
There was a problem hiding this comment.
How
Suggested change
| <p>Total Authored Challenges: ${this.userData.codeChallenges.totalAuthored}</p> | |
| <p>Total Authored Challenges: ${this.userData.codeChallenges.totalAuthored}</p> |
How would you only show this line if totalAuthored had a value of greater than zero?
| color: var(--rank); | ||
| border: 3px solid; | ||
| padding: .25em .5em; | ||
| color: var(--rank); |
Member
There was a problem hiding this comment.
Suggested change
| color: var(--rank); | |
| color: var(--rank); | |
| background: black; |
Hard to read!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.